-
Notifications
You must be signed in to change notification settings - Fork 462
[release-4.5] Bug 1904082: ctrcfg_test: Wait for our prior target config #2284 #2284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.5] Bug 1904082: ctrcfg_test: Wait for our prior target config #2284 #2284
Conversation
Waiting for the previous MC isn't right here; we're deleting a config and so what we want to wait for is the previous pool target. Drop the racy `sleep()`.
|
@openshift-cherrypick-robot: Bugzilla bug 1899368 has been cloned as Bugzilla bug 1904082. Retitling PR to link against new bug. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retitle [release-4.5] Bug 1899368: ctrcfg_test: Wait for our prior target config |
|
/retitle [release-4.5] Bug 1899368: ctrcfg_test: Wait for our prior target config |
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1899368, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1904082, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 6 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/bugzilla refresh |
|
@rphillips: This pull request references Bugzilla bug 1899368, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retitle [release-4.5] Bug 1904082: ctrcfg_test: Wait for our prior target config #2284 |
|
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1904082, which is valid. 6 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
e2e-gcp-op failed with a gcp quota error... will retry later |
|
/assign |
|
this is blocking some 4.5 bzs but also being blocked by the gcp/aws outages... =/ |
|
/lgtm |
|
/test e2e-gcp-op |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kikisdeliveryservice, openshift-cherrypick-robot, rphillips The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-agnostic-upgrade |
|
As this PR is only exercised in e2e-gcp-op test runs since it is a change to an e2e-gcp-op test and the bug in the test it is fixing is blocking all 4.5 backports in our repo now (including #2247), I'm overriding. /override ci/prow/e2e-agnostic-upgrade |
|
@kikisdeliveryservice: Overrode contexts on behalf of kikisdeliveryservice: ci/prow/e2e-agnostic-upgrade DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged: Bugzilla bug 1904082 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #2239
/assign rphillips